From: Seraphime Kirkovski Date: Tue, 4 Apr 2017 12:40:48 +0000 (+0200) Subject: libxc: fix segfault on uninitialized xch->fmem X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~2358 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/%22bookmarks:/?a=commitdiff_plain;h=c4bdbec00c9063736361124a3492ebceabfaed06;p=xen.git libxc: fix segfault on uninitialized xch->fmem Currently in xc_interface_open, xch->fmem is not initialized and in some rare case the code fails before ever assigning a value to it. I got this in master: $ sudo ./xl/xl run xencall: error: Could not obtain handle on privileged command interface: No such file or directory Segmentation fault This initializes the whole xch_buff to 0. Signed-off-by: Seraphime Kirkovski Acked-by: Wei Liu --- diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index 72e6242417..f395594a8f 100644 --- a/tools/libxc/xc_private.c +++ b/tools/libxc/xc_private.c @@ -30,7 +30,7 @@ struct xc_interface_core *xc_interface_open(xentoollog_logger *logger, xentoollog_logger *dombuild_logger, unsigned open_flags) { - struct xc_interface_core xch_buf, *xch = &xch_buf; + struct xc_interface_core xch_buf = { 0 }, *xch = &xch_buf; xch->flags = open_flags; xch->dombuild_logger_file = 0;